Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep more specific cell styling instead of it being overwritten by the table cell_style #143

Merged

Conversation

petergoldstein
Copy link
Contributor

This is a rebased and updated version of #59, which addressed #56.

Thanks to @russellsanders for the original contribution.

@pointlessone I believe this can be merged. Can you please take a look?

CHANGELOG.md Outdated Show resolved Hide resolved
lib/prawn/table.rb Outdated Show resolved Hide resolved
@petergoldstein
Copy link
Contributor Author

@pointlessone Review issues have been addressed, so this is likely ready for merge.

@pointlessone pointlessone merged commit 066dc26 into prawnpdf:master Feb 17, 2022
@mojavelinux
Copy link
Contributor

mojavelinux commented Jul 11, 2022

This is a significant breaking change which affects Asciidoctor PDF. The problem is that the :cell_style option on the table no longer gets applied to each custom cell implementation. Before, setting :cell_style would be passed to cell_style=, which in turn would be passed to cells.style. That no longer happens, and make_cells does not pass options to a cell that's already been constructed. So, essentially, the code path has changed.

I can likely find a way to work around it (see asciidoctor/asciidoctor-pdf@9d30122), but I just wanted you to be aware that the change does break widely used code when you decide how to version the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants