Adjust behavior for pod labels #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 85.11% // Head: 85.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
=======================================
Coverage 85.11% 85.12%
=======================================
Files 12 12
Lines 1612 1613 +1
=======================================
+ Hits 1372 1373 +1
Misses 155 155
Partials 85 85
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Pod labels from the Spec.Pod.Labels were previously not propagated to the StatefulSet.Template. This change notes the differences between the two Label locations in the ZookeeperCluster CRD and denotes priority ordering. Signed-off-by: Nick Huanca <[email protected]>
endzyme
force-pushed
the
fix-pod-label-spec
branch
from
c6736e9 to
4fed284
Compare
|
looks good to me. |
|
Thanks all! |
|
Any idea when the next release will be? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Pod labels from the Spec.Pod.Labels were previously not propagated to the StatefulSet.Template.
Purpose of the change
Resolves #511
What the code does
How to verify it