Adds nodeSelector, affinity and tolerations to the pre-delete hook Job

[georgekaz]

make delete Job respect scheduling choices

Change log description

Makes the delete job respect node scheduling the same as the post install hooks do. Without this, it fails in a mixed windows/linux cluster.

Purpose of the change

Fixes #518
Fixes apache/solr-operator#382

What the code does

Adds a node selector to control pre-delete Job scheduling

How to verify it

Deploy and remove. See that it schedules where you expect it to.

[codecov]

Codecov Report

Base: 85.12% // Head: 85.12% // No change to project coverage 👍

Coverage data is based on head (d06ac50) compared to base (66fcc71).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files          12       12           
  Lines        1613     1613           
=======================================
  Hits         1373     1373           
  Misses        155      155           
  Partials       85       85           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jkhalack]

One day we might want to split the hook and the operator settings (in case they would need to be different).

The current change LGTM, as it goes along with the other hook.

[anishakj]

LGTM