Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version to 1.18 #499

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Bump go version to 1.18 #499

merged 1 commit into from
Oct 21, 2022

Conversation

AKamyshnikova
Copy link
Contributor

Also updated setup for controller-gen and kustomize.

Signed-off-by: Ann Taraday [email protected]

Change log description

  • update go.mod and Dockerfile build base image
  • update setup for controller-gen and kustomize

Purpose of the change

Fixes #498

What the code does

Use 1.18 go

How to verify it

Build image, run e2e tests

Update setup for controller-gen and kustomize.

Signed-off-by: Ann Taraday <[email protected]>
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #499 (e9f2a44) into master (ed16dab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files          12       12           
  Lines        1606     1606           
=======================================
  Hits         1366     1366           
  Misses        155      155           
  Partials       85       85           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AKamyshnikova
Copy link
Contributor Author

@anishakj Hello! Could you take a look at this PR?

@Amit-Singh40
Copy link
Contributor

I have tested this and it is working fine.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit ae23010 into pravega:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump go version to 1.18
3 participants