Issue 475: use socat instead of nc #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfred Landrum <[email protected]>
Codecov ReportBase: 85.05% // Head: 85.05% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
=======================================
Coverage 85.05% 85.05%
=======================================
Files 12 12
Lines 1606 1606
=======================================
Hits 1366 1366
Misses 155 155
Partials 85 85 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Slach
added a commit
to Altinity/clickhouse-operator
that referenced
this pull request
May 23, 2022
…st_zookeeper_pvc_probes_workload, wait when pravega/zookeeper-operator#476 will merge Signed-off-by: Slach <[email protected]>
|
@anishakj build pass, could you merge PR? |
|
@alfred-landrum Could you please run e2e tests using the zookeeper image |
alfred-landrum
force-pushed
the
upstream-use-socat
branch
from
c920bc6 to
1f3cd8c
Compare
|
@alfred-landrum could you merge master to your branch? |
dariothornhill
approved these changes
Sep 21, 2022
|
Hi @derekm Any predictions to approve? |
derekm
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alfred Landrum [email protected]
Change log description
Replace usage of
ncwithsocatfor zookeeper 4 letter word commands.Purpose of the change
Fixes #475