Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue testing #451

Closed
wants to merge 27 commits into from
Closed

Issue testing #451

wants to merge 27 commits into from

Conversation

anishakj
Copy link
Contributor

Change log description

(2-3 concise points about the changes in this PR. When committing this PR, the committer is expected to copy the content of this section to the merge description box)

Purpose of the change

(e.g., Fixes #666, Closes #1234)

What the code does

(Detailed description of the code changes)

How to verify it

(Steps to verify that the changes are effective)

tmarcu and others added 2 commits March 31, 2022 06:05
The replace blocks should only be used temporarily unless an imported
package forces them on. To make zookeeper more importable by other
packages, don't use any replace directies that will require the parent
package to also set them.

Update Kubernetes version to 1.23.1 and controller runtime to 0.11.1.

Signed-off-by: Tudor Marcu <[email protected]>
Signed-off-by: anishakj <[email protected]>
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #451 (d661577) into master (2c46990) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head d661577 differs from pull request most recent head 9b75100. Consider uploading reports for the commit 9b75100 to get more accurate results

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   85.20%   85.01%   -0.19%     
==========================================
  Files          12       12              
  Lines        1602     1602              
==========================================
- Hits         1365     1362       -3     
- Misses        153      155       +2     
- Partials       84       85       +1     
Impacted Files Coverage Δ
controllers/zookeepercluster_controller.go 65.46% <100.00%> (-0.61%) ⬇️
pkg/zk/generators.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c46990...9b75100. Read the comment docs.

anishakj and others added 25 commits March 31, 2022 07:05
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: Tudor Marcu <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
@anishakj
Copy link
Contributor Author

anishakj commented Apr 8, 2022

closing this PR as it is fixed in #449

@anishakj anishakj closed this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants