Issue 417: Harden zookeeper post-install hook #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anishakj <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 12 12
Lines 1643 1643
=======================================
Hits 1382 1382
Misses 177 177
Partials 84 84 Continue to review full report at Codecov.
|
nishant-yt
reviewed
Dec 2, 2021
| @@ -69,7 +69,7 @@ config: {} | |||
| # autoPurgePurgeInterval: 1 | |||
| # quorumListenOnAllIPs: false | |||
| # additionalConfig: {} | |||
|
|
|||
There was a problem hiding this comment.
Nit: can you remove the extra whitespace
nishant-yt
approved these changes
Dec 2, 2021
derekm
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anishakj [email protected]
Change log description
Added more validations in zookeeper post install hook.
Also changed the
preallocsizeto16MBin values files, to reduce transactional log size.Purpose of the change
Fixes #417
What the code does
Added more validations in post install hook, so that hook will succeed only after all the zookeeper pods are ready.
How to verify it
Verified zookeeper cluster installation