Add omitempty to optional probe fields #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Houston Putman <[email protected]>
HoustonPutman
force-pushed
the
omitempty-fix
branch
from
ab6fd3c to
0b877f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
=======================================
Coverage 86.00% 86.00%
=======================================
Files 11 11
Lines 1572 1572
=======================================
Hits 1352 1352
Misses 147 147
Partials 73 73
Continue to review full report at Codecov.
|
anishakj
reviewed
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Fix issue with empty probes section in ZookeeperCluster using the golang client. Adds omitempty to the json serialization spec.
Purpose of the change
Fixes #378