Issue 357: Fix for error messages coming in operator logs

[anishakj]

Signed-off-by: anishakj [email protected]

Change log description

In ClearUpgradeStatus() function, we were not updating the zookeeper cluster, only the status was getting updated 2 times. Due to that again we try to update the cluster, was getting error as below.

, Operation cannot be fulfilled on zookeeperclusters.zookeeper.pravega.io \"zookeeper\": the object has been modified; please apply your changes to the latest version and try again"

Purpose of the change

_Fixes #357

What the code does

Update the cluster instance correctly

How to verify it

Verify that during upgrade of zookeeper cluster, error messages are not coming frequently in operator logs.

[codecov-commenter]

Codecov Report

Merging #367 (c64ed55) into master (3359647) will increase coverage by 1.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   84.58%   85.75%   +1.16%     
==========================================
  Files          11       11              
  Lines        1382     1551     +169     
==========================================
+ Hits         1169     1330     +161     
- Misses        140      145       +5     
- Partials       73       76       +3     

Impacted Files	Coverage Δ
...er/zookeepercluster/zookeepercluster_controller.go	61.72% <100.00%> (+1.24%)	⬆️
pkg/zk/generators.go	100.00% <0.00%> (ø)
pkg/utils/test_utils.go	100.00% <0.00%> (ø)
pkg/zk/synchronizers.go	100.00% <0.00%> (ø)
pkg/utils/zookeeper_util.go	100.00% <0.00%> (ø)
pkg/utils/finalizer_utils.go	100.00% <0.00%> (ø)
pkg/apis/zookeeper/v1beta1/status.go	100.00% <0.00%> (ø)
...g/apis/zookeeper/v1beta1/zookeepercluster_types.go	98.77% <0.00%> (+0.09%)	⬆️
...kg/apis/zookeeper/v1beta1/zz_generated.deepcopy.go	98.03% <0.00%> (+0.40%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3359647...c64ed55. Read the comment docs.

[amuraru]

+1

[amuraru]

Tested this in my environment and works fine

[anishakj]

Tested this in my environment and works fine

@amuraru Thanks for confirming

[SrishT]

LGTM