Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rbac cluster role #362

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Fix rbac cluster role #362

merged 2 commits into from
Jul 6, 2021

Conversation

mikechengwei
Copy link
Contributor

Rbac clusterrole add service accounts authorization.

Purpose of the change

Fix #361

@anishakj
Copy link
Contributor

anishakj commented Jul 5, 2021

@mikechengwei could you please update in https://github.com/pravega/zookeeper-operator/blob/master/deploy/default_ns/rbac.yaml as well

Also wanted to update that we recommend helm charts for all the install and upgrade work flow.

@mikechengwei
Copy link
Contributor Author

@anishakj I have updated.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #362 (767c19a) into master (b18f163) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   84.52%   84.52%           
=======================================
  Files          11       11           
  Lines        1376     1376           
=======================================
  Hits         1163     1163           
  Misses        140      140           
  Partials       73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18f163...767c19a. Read the comment docs.

@anishakj anishakj merged commit d0a17da into pravega:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart rbac failed to list serviceaccounts.
3 participants