Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 328: Add support of customized volumeMounts for zookeeper container #327

Merged
merged 6 commits into from
May 27, 2021

Conversation

CraneShiEMC
Copy link
Contributor

@CraneShiEMC CraneShiEMC commented May 14, 2021

Change log description

Added a new field volumeMounts in ZookeeperClusterSpec so that users can set customized volumeMounts for zookeeper container to mount customized volumes user specified.

Purpose of the change

Fixes #328

What the code does

Added a new field volumeMounts in ZookeeperClusterSpec and the customized volumeMounts specified can be added to the zookeeper container.

How to verify it

Verified that able to configure customized volumeMounts for zk container and successfully mounted the customized volumes to the zk container.

CraneShiEMC and others added 2 commits May 13, 2021 15:23
@CraneShiEMC CraneShiEMC changed the title Add support of customized volumeMounts Issue 328: Add support of customized volumeMounts May 14, 2021
@CraneShiEMC CraneShiEMC changed the title Issue 328: Add support of customized volumeMounts Issue 328: Add support of customized volumeMounts for zookeeper container May 14, 2021
@realAaronWu
Copy link
Contributor

Please add UT coverage for the Spec.VolumeMounts.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2021

Codecov Report

Merging #327 (a8c3ea3) into master (a99c93b) will decrease coverage by 1.54%.
The diff coverage is 35.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
- Coverage   84.67%   83.13%   -1.55%     
==========================================
  Files          11       11              
  Lines        1312     1352      +40     
==========================================
+ Hits         1111     1124      +13     
- Misses        133      157      +24     
- Partials       68       71       +3     
Impacted Files Coverage Δ
...g/apis/zookeeper/v1beta1/zookeepercluster_types.go 98.68% <ø> (ø)
...kg/apis/zookeeper/v1beta1/zz_generated.deepcopy.go 88.97% <32.50%> (-11.03%) ⬇️
pkg/zk/generators.go 99.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99c93b...a8c3ea3. Read the comment docs.

@CraneShiEMC
Copy link
Contributor Author

Please add UT coverage for the Spec.VolumeMounts.

Added now

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit a5cee3b into pravega:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support customized volumeMounts for zookeeper container
4 participants