-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 328: Add support of customized volumeMounts for zookeeper container #327
Issue 328: Add support of customized volumeMounts for zookeeper container #327
Conversation
Signed-off-by: Shi, Crane <[email protected]>
Signed-off-by: Aaron Wu <[email protected]>
Please add UT coverage for the Spec.VolumeMounts. |
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
- Coverage 84.67% 83.13% -1.55%
==========================================
Files 11 11
Lines 1312 1352 +40
==========================================
+ Hits 1111 1124 +13
- Misses 133 157 +24
- Partials 68 71 +3
Continue to review full report at Codecov.
|
Added now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change log description
Added a new field volumeMounts in ZookeeperClusterSpec so that users can set customized volumeMounts for zookeeper container to mount customized volumes user specified.
Purpose of the change
Fixes #328
What the code does
Added a new field volumeMounts in ZookeeperClusterSpec and the customized volumeMounts specified can be added to the zookeeper container.
How to verify it
Verified that able to configure customized volumeMounts for zk container and successfully mounted the customized volumes to the zk container.