Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 312: list PVC with ZookeeperCluster uid #313

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

srteam2020
Copy link
Contributor

@srteam2020 srteam2020 commented Mar 20, 2021

Change log description

Add UID as a label for each PVC in MakeStatefulSet and list PVC using the UID in getPVCList.

Purpose of the change

Fix #312.

What the code does

  • MakeStatefulSet: One more label, uid, when creating VolumeClaimTemplates
  • getPVCList: List the PVC with the uid of the current ZookeeperCluster

How to verify it

@codecov-io
Copy link

Codecov Report

Merging #313 (a687e91) into master (cda03d2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   84.64%   84.64%           
=======================================
  Files          11       11           
  Lines        1309     1309           
=======================================
  Hits         1108     1108           
  Misses        133      133           
  Partials       68       68           
Impacted Files Coverage Δ
...er/zookeepercluster/zookeepercluster_controller.go 60.67% <100.00%> (ø)
pkg/zk/generators.go 99.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda03d2...a687e91. Read the comment docs.

@srteam2020 srteam2020 changed the title list PVC with ZookeeperCluster uid Issue 312: list PVC with ZookeeperCluster uid Mar 20, 2021
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PVC can be mistakenly deleted when reading from stale apiserver
3 participants