Issue 300: Zookeeper Operator pre-delete hook

[SrishT]

Signed-off-by: SrishT [email protected]

Change log description

Provides a pre-delete hook which ensures that custom resources are deleted before deleting the operator.

Purpose of the change

Fixes #300

What the code does

Allows the operator to be deleted via helm only if the zookeepercluster custom resource has already been deleted, not otherwise.

How to verify it

• If you try to delete the zookeeper operator before having deleted the zookeeper cluster resource, the pre-delete job will fail, thereby not allowing the operator from being deleted.
• If you try to delete the zookeeper operator after the zookeeper cluster resource has been cleaned up successfully, the operator will also be successfully deleted.

[codecov-io]

Codecov Report

Merging #301 (2a72101) into master (b875bba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   84.64%   84.64%           
=======================================
  Files          11       11           
  Lines        1309     1309           
=======================================
  Hits         1108     1108           
  Misses        133      133           
  Partials       68       68           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b875bba...2a72101. Read the comment docs.

[jkhalack]

LGTM

[anishakj]

Do we need to ensure role and role bindings deleted in addition to the cluster role?

[SrishT]

Do we need to ensure role and role bindings deleted in addition to the cluster role?

@anishakj we are only ensuring that the zookeepercluster custom resource has only been deleted before triggering the delete. We are not checking for the RBAC being already deleted since it is going to be deleted by this chart itself.

[anishakj]

LGTM