Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 185: support for imagepullsecrets field added #272

Merged
merged 8 commits into from
Nov 17, 2020

Conversation

Prabhaker24
Copy link
Contributor

Change log description

Support for imagepullsecret added for allowing pull of images in a private repository.

Purpose of the change

Fixes #185

What the code does

imagepullsecret is added as part of pod policy and works with any other service account other than default and allows to do pull for images from a private repository

How to verify it

Following is tested and works:-

  1. zookeeper cluster deployment with the zookeeper image in a private repo works for a non-default service account when correct imagepullsecret is specified.
  2. zookeeper cluster deployment with the zookeeper image in public repository works for both default and non-default service account.

prabhaker24 added 4 commits November 14, 2020 17:43
Signed-off-by: prabhaker24 <[email protected]>
Signed-off-by: prabhaker24 <[email protected]>
@Prabhaker24 Prabhaker24 marked this pull request as ready for review November 17, 2020 06:18
@Prabhaker24 Prabhaker24 requested review from anishakj and SrishT and removed request for anishakj November 17, 2020 06:18
@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #272 (c439afe) into master (540aae6) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   84.01%   84.07%   +0.06%     
==========================================
  Files          11       11              
  Lines        1201     1206       +5     
==========================================
+ Hits         1009     1014       +5     
  Misses        129      129              
  Partials       63       63              
Impacted Files Coverage Δ
...g/apis/zookeeper/v1beta1/zookeepercluster_types.go 98.46% <ø> (ø)
...kg/apis/zookeeper/v1beta1/zz_generated.deepcopy.go 100.00% <100.00%> (ø)
pkg/zk/generators.go 99.22% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 540aae6...c439afe. Read the comment docs.

Signed-off-by: prabhaker24 <[email protected]>
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prabhaker24 added 3 commits November 17, 2020 17:29
Signed-off-by: prabhaker24 <[email protected]>
Signed-off-by: prabhaker24 <[email protected]>
Signed-off-by: prabhaker24 <[email protected]>
Copy link
Contributor

@SrishT SrishT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 13284a1 into master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImagePullSecrets field is not supported
5 participants