-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 185: support for imagepullsecrets field added #272
Conversation
Signed-off-by: prabhaker24 <[email protected]>
…into Issue-185-support-imagepullsecrets-field
Signed-off-by: prabhaker24 <[email protected]>
Signed-off-by: prabhaker24 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
+ Coverage 84.01% 84.07% +0.06%
==========================================
Files 11 11
Lines 1201 1206 +5
==========================================
+ Hits 1009 1014 +5
Misses 129 129
Partials 63 63
Continue to review full report at Codecov.
|
Signed-off-by: prabhaker24 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: prabhaker24 <[email protected]>
Signed-off-by: prabhaker24 <[email protected]>
Signed-off-by: prabhaker24 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change log description
Support for imagepullsecret added for allowing pull of images in a private repository.
Purpose of the change
Fixes #185
What the code does
imagepullsecret is added as part of pod policy and works with any other service account other than default and allows to do pull for images from a private repository
How to verify it
Following is tested and works:-