Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 220: Added support for more zookeeper configuration options #262

Merged
merged 5 commits into from
Oct 22, 2020

Conversation

anishakj
Copy link
Contributor

Signed-off-by: anisha.kj [email protected]

Change log description

Added more zookeeper configuration options in zookeeper configmap.

Purpose of the change

Fixes #220, #224

What the code does

Added more options as part of zookeeper spec under config, so that users are able to configure these values

How to verify it

Able to set the configuration options, and pod should come up with the values set.

@codecov-io
Copy link

Codecov Report

Merging #262 into master will increase coverage by 0.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   83.37%   83.90%   +0.52%     
==========================================
  Files          11       11              
  Lines        1155     1193      +38     
==========================================
+ Hits          963     1001      +38     
  Misses        129      129              
  Partials       63       63              
Impacted Files Coverage Δ
...g/apis/zookeeper/v1beta1/zookeepercluster_types.go 98.43% <100.00%> (+0.25%) ⬆️
pkg/zk/generators.go 99.21% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cef7c5...2cc8592. Read the comment docs.

Copy link
Contributor

@Prabhaker24 Prabhaker24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have entered some empty comments at some places other than that this Pr LGTM.

@anishakj anishakj merged commit cc11ea6 into master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting maxclientcnxns
4 participants