Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-257 Propagate labels to ZookeeperCluster underlying resources #258

Merged
merged 1 commit into from
Oct 13, 2020
Merged

ISSUE-257 Propagate labels to ZookeeperCluster underlying resources #258

merged 1 commit into from
Oct 13, 2020

Conversation

amuraru
Copy link
Contributor

@amuraru amuraru commented Oct 12, 2020

Fixes: #257

spiegela
spiegela reviewed Oct 13, 2020
View reviewed changes
Copy link
Contributor

@spiegela spiegela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I was needing this exact fix myself. Could you also add unit tests for these labels?

@amuraru
Copy link
Contributor Author

amuraru commented Oct 13, 2020

added unit tests

spiegela
spiegela approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@spiegela spiegela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Perfect. Thanks!

anishakj
anishakj approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit e100c87 into pravega:master Oct 13, 2020
@amuraru amuraru deleted the labels branch October 18, 2020 21:01
@endzyme
Copy link
Contributor

endzyme commented Nov 1, 2022

I think this may have broken somewhere along the way. I am unable to propagate labels down to the statefulset nor the pods. I will open an issue for this.

@endzyme
Copy link
Contributor

endzyme commented Nov 1, 2022

Ah - the problem is that labels from spec.labels are propagated to pods, but not spec.pod.labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishakj anishakj anishakj approved these changes

@spiegela spiegela spiegela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZookeeperCluster spec.labels are not propagated to StatefuleSet/Pods created by the operator
4 participants
@amuraru @endzyme @spiegela @anishakj