-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 241: Chart changes and CRD refactoring #242
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SrishT <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 81.81% 81.16% -0.66%
==========================================
Files 11 11
Lines 1248 1258 +10
==========================================
Hits 1021 1021
- Misses 162 170 +8
- Partials 65 67 +2
Continue to review full report at Codecov.
|
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
* support mutli images * add descriptions for containers and volumes fields and run operator-sdk to update crds Co-authored-by: qzuo <[email protected]>
* Operator chart: added nodeselector, affinity and tolerations * Fixed syntax * Fixed syntax * Fixing hooks * Added defaults * Removed unneeded imagePullSecrets * Removed unneeded imagePullSecrets
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
…zookeeper-operator into issue-241-helm-upgrades
Signed-off-by: SrishT <[email protected]>
Closing this PR as it has been replaced with #245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SrishT [email protected]
Change log description
Helm upgrade of the zookeeper operator and zookeeper cluster from 0.2.8 to 0.2.9-rc0 is failing. Also the
additionalPrinterColumns
from the ZookeeperCluster CRD have been removed.Purpose of the change
Fixed #241
What the code does
Changes the location of the CRD from the
crds/
since that was causing the operator upgrade from 0.2.8 to 0.2.9-rc0 to fail, and adds theadditionalPrinterColumns
back into the ZookeeperCluster CRD. Also adds default value for thestorageType
andkubernetesClusterDomain
fields so that helm upgrade of the zookeeper cluster using thereuse-values
flag does not fail.How to verify it