Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 241: Chart changes and CRD refactoring #242

Closed
wants to merge 10 commits into from

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Sep 15, 2020

Signed-off-by: SrishT [email protected]

Change log description

Helm upgrade of the zookeeper operator and zookeeper cluster from 0.2.8 to 0.2.9-rc0 is failing. Also the additionalPrinterColumns from the ZookeeperCluster CRD have been removed.

Purpose of the change

Fixed #241

What the code does

Changes the location of the CRD from the crds/ since that was causing the operator upgrade from 0.2.8 to 0.2.9-rc0 to fail, and adds the additionalPrinterColumns back into the ZookeeperCluster CRD. Also adds default value for the storageType and kubernetesClusterDomain fields so that helm upgrade of the zookeeper cluster using the reuse-values flag does not fail.

How to verify it

  • Helm upgrade of zookeeper operator from 0.2.8 to 0.2.9-rc0 should succeed.
  • Helm upgrade of zookeeper cluster from 0.2.8 0.2.9-rc0 should succeed both with and without the reuse-values flag.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2020

Codecov Report

Merging #242 into master will decrease coverage by 0.65%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   81.81%   81.16%   -0.66%     
==========================================
  Files          11       11              
  Lines        1248     1258      +10     
==========================================
  Hits         1021     1021              
- Misses        162      170       +8     
- Partials       65       67       +2     
Impacted Files Coverage Δ
...g/apis/zookeeper/v1beta1/zookeepercluster_types.go 98.30% <ø> (ø)
...kg/apis/zookeeper/v1beta1/zz_generated.deepcopy.go 82.03% <0.00%> (-4.19%) ⬇️
pkg/zk/generators.go 98.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5502fb...ea02263. Read the comment docs.

SrishT and others added 9 commits September 15, 2020 20:12
* support mutli images

* add descriptions for containers and volumes fields and run operator-sdk to update crds

Co-authored-by: qzuo <[email protected]>
* Operator chart: added nodeselector, affinity and tolerations

* Fixed syntax

* Fixed syntax

* Fixing hooks

* Added defaults

* Removed unneeded imagePullSecrets

* Removed unneeded imagePullSecrets
Signed-off-by: SrishT <[email protected]>
@SrishT
Copy link
Contributor Author

SrishT commented Sep 17, 2020

Closing this PR as it has been replaced with #245

@SrishT SrishT closed this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make changes to allow helm upgrades using "reuse-values"
4 participants