Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator can watch a configurable set of namespaces #201

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

amuraru
Copy link
Contributor

@amuraru amuraru commented Jun 16, 2020

Change log description

This patch extends the watch mechanism in operator so the ZookeeperCluster resources can be deployed in different namespaces than where the operator runs.

Purpose of the change

Fixes #142

How to verify it

(Steps to verify that the changes are effective)

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   82.82%   82.82%           
=======================================
  Files          11       11           
  Lines        1223     1223           
=======================================
  Hits         1013     1013           
  Misses        142      142           
  Partials       68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72fd1b8...4eb4c99. Read the comment docs.

@anishakj
Copy link
Contributor

I have tested below scenarios

  1. Created operator in WATCH_NAMESPACE "" and created clusters in default and non default name spaces
  2. Created operator in WATCH_NAMESPACE "ns1, ns2" and created clusters in ns1 and ns2
  3. Created operator in WATCH_NAMESPACE "dev" and created cluster in dev namespace
    All scenarios have worked

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 1039e7a into pravega:master Jul 24, 2020
@amuraru amuraru deleted the issue-142 branch August 27, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZK Operator should be able to watch a configurable set of namespaces
3 participants