-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue-494] FLIP-107: Expose metadata for the new table source #504
[Issue-494] FLIP-107: Expose metadata for the new table source #504
Conversation
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
============================================
+ Coverage 82.48% 82.97% +0.48%
- Complexity 487 498 +11
============================================
Files 44 45 +1
Lines 2284 2326 +42
Branches 224 231 +7
============================================
+ Hits 1884 1930 +46
+ Misses 236 230 -6
- Partials 164 166 +2
Continue to review full report at Codecov.
|
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
b9277e4
to
1734661
Compare
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
src/main/java/io/pravega/connectors/flink/dynamic/table/FlinkPravegaDynamicTableSource.java
Outdated
Show resolved
Hide resolved
src/main/java/io/pravega/connectors/flink/dynamic/table/FlinkPravegaDynamicTableSource.java
Outdated
Show resolved
Hide resolved
src/main/java/io/pravega/connectors/flink/dynamic/table/FlinkPravegaDynamicTableSource.java
Outdated
Show resolved
Hide resolved
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
Signed-off-by: zhongle.wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Change log description
FLIP-107 has added the support for metadata along with the event for both table source and sink.
For table source, we export the
EventPointer
in the table source. By doing this, we can cover the benifit similar with #180 for DataStream Source.Purpose of the change
Fixes #494
What the code does
FlinkPravegaDynamicDeserializationSchema
that expose the metadata from theEventRead
. For now, onlyEventPointer
is supported as the other two (scope
adnstream
) is not exposed from Pravega.SupportsReadingMetadata
forFlinkPravegaDynamicTableSource
.How to verify it
./gradlew clean build
passes.