forked from apache/arrow
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GDV-43: [C++] Introduce error codes as error handling strategy. (apac…
…he#8) * GDV-43: [C++] Introduce error codes as error handling strategy. Introduced status codes and using the same as the error handling strategy. The decision was taken to accommodate existing libraries that use error codes and because Arrow also uses error codes and not exception. Changed the signatures across the board for the same.
- Loading branch information
1 parent
366e2c2
commit c3b6ce4
Showing
15 changed files
with
503 additions
and
174 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,166 @@ | ||
| /* | ||
| * Copyright (C) 2017-2018 Dremio Corporation | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| * Adapted from Apache Arrow Status. | ||
| */ | ||
| #ifndef GANDIVA_STATUS_H | ||
| #define GANDIVA_STATUS_H | ||
|
|
||
| #include <string> | ||
| #include <utility> | ||
|
|
||
| #define GANDIVA_RETURN_NOT_OK(status) \ | ||
| do { \ | ||
| Status _status = (status); \ | ||
| if (!_status.ok()) { \ | ||
| std::stringstream ss; \ | ||
| ss << __FILE__ << ":" << __LINE__ << " code: " << #status << "\n" << _status.message(); \ | ||
| return Status(_status.code(), ss.str()); \ | ||
| } \ | ||
| } while (0) | ||
|
|
||
| #define GANDIVA_RETURN_FAILURE_IF_FALSE(condition, status) \ | ||
| do { \ | ||
| if (!condition) { \ | ||
| Status _status = (status); \ | ||
| std::stringstream ss; \ | ||
| ss << __FILE__ << ":" << __LINE__ << " code: " << #status << "\n" << _status.message(); \ | ||
| return Status(_status.code(), ss.str()); \ | ||
| } \ | ||
| } while (0) | ||
|
|
||
| namespace gandiva { | ||
|
|
||
| enum class StatusCode : char { | ||
| OK = 0, | ||
| CodeGenError = 1 | ||
| }; | ||
|
|
||
| class Status { | ||
| public: | ||
| // Create a success status. | ||
| Status() : state_(NULL) {} | ||
| ~Status() { delete state_; } | ||
|
|
||
| Status(StatusCode code, const std::string& msg); | ||
|
|
||
| // Copy the specified status. | ||
| Status(const Status& s); | ||
| Status& operator=(const Status& s); | ||
|
|
||
| // Move the specified status. | ||
| Status(Status&& s); | ||
| Status& operator=(Status&& s); | ||
|
|
||
| // AND the statuses. | ||
| Status operator&(const Status& s) const; | ||
| Status operator&(Status&& s) const; | ||
| Status& operator&=(const Status& s); | ||
| Status& operator&=(Status&& s); | ||
|
|
||
| // Return a success status. | ||
| static Status OK() { return Status(); } | ||
|
|
||
| // Return error status of an appropriate type. | ||
| static Status CodeGenError(const std::string& msg) { | ||
| return Status(StatusCode::CodeGenError, msg); | ||
| } | ||
|
|
||
| // Returns true if the status indicates success. | ||
| bool ok() const { return (state_ == NULL); } | ||
|
|
||
| bool IsCodeGenError() const { return code() == StatusCode::CodeGenError; } | ||
|
|
||
| // Return a string representation of this status suitable for printing. | ||
| // Returns the string "OK" for success. | ||
| std::string ToString() const; | ||
|
|
||
| // Return a string representation of the status code, without the message | ||
| // text or posix code information. | ||
| std::string CodeAsString() const; | ||
|
|
||
| StatusCode code() const { return ok() ? StatusCode::OK : state_->code; } | ||
|
|
||
| std::string message() const { return ok() ? "" : state_->msg; } | ||
|
|
||
| private: | ||
| struct State { | ||
| StatusCode code; | ||
| std::string msg; | ||
| }; | ||
| // OK status has a `NULL` state_. Otherwise, `state_` points to | ||
| // a `State` structure containing the error code and message(s) | ||
| State* state_; | ||
|
|
||
| void CopyFrom(const Status& s); | ||
| void MoveFrom(Status& s); | ||
| }; | ||
|
|
||
| static inline std::ostream& operator<<(std::ostream& os, const Status& x) { | ||
| os << x.ToString(); | ||
| return os; | ||
| } | ||
|
|
||
| inline Status::Status(const Status& s) | ||
| : state_((s.state_ == NULL) ? NULL : new State(*s.state_)) {} | ||
|
|
||
| inline Status& Status::operator=(const Status& s) { | ||
| // The following condition catches both aliasing (when this == &s), | ||
| // and the common case where both s and *this are ok. | ||
| if (state_ != s.state_) { | ||
| CopyFrom(s); | ||
| } | ||
| return *this; | ||
| } | ||
|
|
||
| inline Status::Status(Status&& s) : state_(s.state_) { s.state_ = NULL; } | ||
|
|
||
| inline Status& Status::operator=(Status&& s) { | ||
| MoveFrom(s); | ||
| return *this; | ||
| } | ||
|
|
||
| inline Status Status::operator&(const Status& s) const { | ||
| if (ok()) { | ||
| return s; | ||
| } else { | ||
| return *this; | ||
| } | ||
| } | ||
|
|
||
| inline Status Status::operator&(Status&& s) const { | ||
| if (ok()) { | ||
| return std::move(s); | ||
| } else { | ||
| return *this; | ||
| } | ||
| } | ||
|
|
||
| inline Status& Status::operator&=(const Status& s) { | ||
| if (ok() && !s.ok()) { | ||
| CopyFrom(s); | ||
| } | ||
| return *this; | ||
| } | ||
|
|
||
| inline Status& Status::operator&=(Status&& s) { | ||
| if (ok() && !s.ok()) { | ||
| MoveFrom(s); | ||
| } | ||
| return *this; | ||
| } | ||
|
|
||
| } // namespace gandiva | ||
| #endif // GANDIVA_STATUS_H |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.