Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: adding sticky notes as a keybind #1636

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DMelisena
Copy link

Pull Request

Description

A simple sticky notes feature. implementation of #1635 feature request. this will :

  1. install https://github.com/vixalien/sticky from aur as a custom install and keybind it to Super+grave
  2. keybind it as a script that check using pgrep, it will spawn if its not opened and close if its already opened
  3. customize the apps as float on windows rule

ps: forgive me for not using the template on commit guidelines. I tried to comply with the contribution guideline but seems to miss it out.
this use the same key as quickphrase feature, i think from fcitx5 and will replace it. I never use the quickphrase feature myself though. I asked around and it seems that no one use it anyway.

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • [X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

240629_23h50m46s_screenshot

Additional context

I missed out the commit message guideline, sorry. I also dont know where window rule should be implemented except on opacity. I Will suggest a documentation update if this seems to be applicable. This is my first try on contributing to an opensource so i wish for guidance.

Add a script to spawn if not opened and close stiky notes otherwise
@Enigma1309
Copy link
Contributor

can we add support for flatpak app too?

@@ -59,3 +59,4 @@ pokemon-colorscripts-git|zsh
lsd|fish
starship|fish
hyprdots-ctl
aur:sticky-notes # ide text editor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in ./custom_apps.lst for optional packages

@mahaveergurjar
Copy link
Contributor

Please add this package in ./custom_apps.lst don't add in ./custom_hypr.lst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants