message_feed: Add channel-settings-link to bookend.

To replace the previous subscribe/subscribe buttons, we add a button to visit channel settings (if not subscribed) or manage channel settings (if subscribed) to trailing bookends. Fixes zulip#32125.
prakhar1144 · Nov 15, 2024 · e0bd371 · e0bd371
1 parent a8f76f1
commit e0bd371
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/web/src/message_list.ts b/web/src/message_list.ts
@@ -437,6 +437,7 @@ export class MessageList {
         }
 
         this.view.render_trailing_bookend(
+            stream_id,
             sub?.name,
             subscribed,
             deactivated,

diff --git a/web/src/message_list_view.ts b/web/src/message_list_view.ts
@@ -1949,6 +1949,7 @@ export class MessageListView {
     }
 
     render_trailing_bookend(
+        stream_id: number,
         stream_name: string | undefined,
         subscribed: boolean,
         deactivated: boolean,
@@ -1961,6 +1962,7 @@ export class MessageListView {
         // partial in message_group.hbs, which do not set is_trailing_bookend.
         const $rendered_trailing_bookend = $(
             render_bookend({
+                stream_id,
                 stream_name,
                 subscribed,
                 deactivated,

diff --git a/web/templates/bookend.hbs b/web/templates/bookend.hbs
@@ -10,13 +10,15 @@
                 {{t "This channel has been archived." }}
             {{else if subscribed }}
                 {{#tr}}
-                    You subscribed to <z-stream-name></z-stream-name>.
+                    You subscribed to <z-stream-name></z-stream-name>. <channel-settings-link></channel-settings-link>
                     {{#*inline "z-stream-name"}}{{> stream_privacy }} {{stream_name}}{{/inline}}
+                    {{#*inline "channel-settings-link"}} <a href="#channels/{{stream_id}}/{{stream_name}}/personal">{{t 'Manage channel settings'}}</a>{{/inline}}
                 {{/tr}}
             {{else if just_unsubscribed }}
                 {{#tr}}
-                    You unsubscribed from <z-stream-name></z-stream-name>.
+                    You unsubscribed from <z-stream-name></z-stream-name>. <channel-settings-link></channel-settings-link>
                     {{#*inline "z-stream-name"}}{{> stream_privacy }} {{stream_name}}{{/inline}}
+                    {{#*inline "channel-settings-link"}} <a href="#channels/{{stream_id}}/{{stream_name}}/general">{{t 'View in channel settings'}}</a>{{/inline}}
                 {{/tr}}
             {{else}}
                 {{#tr}}

diff --git a/web/tests/message_list.test.cjs b/web/tests/message_list.test.cjs
@@ -366,11 +366,13 @@ run_test("bookend", ({override}) => {
         list.update_trailing_bookend();
         assert.equal(stub.num_calls, 1);
         const bookend = stub.get_args(
+            "stream_id",
             "stream_name",
             "subscribed",
             "deactivated",
             "just_unsubscribed",
         );
+        assert.equal(bookend.stream_id, 5);
         assert.equal(bookend.stream_name, "IceCream");
         assert.equal(bookend.subscribed, true);
         assert.equal(bookend.deactivated, false);
@@ -386,11 +388,13 @@ run_test("bookend", ({override}) => {
         list.update_trailing_bookend();
         assert.equal(stub.num_calls, 1);
         const bookend = stub.get_args(
+            "stream_id",
             "stream_name",
             "subscribed",
             "deactivated",
             "just_unsubscribed",
         );
+        assert.equal(bookend.stream_id, 5);
         assert.equal(bookend.stream_name, "IceCream");
         assert.equal(bookend.subscribed, false);
         assert.equal(bookend.deactivated, false);
@@ -406,11 +410,13 @@ run_test("bookend", ({override}) => {
         list.update_trailing_bookend();
         assert.equal(stub.num_calls, 1);
         const bookend = stub.get_args(
+            "stream_id",
             "stream_name",
             "subscribed",
             "deactivated",
             "just_unsubscribed",
         );
+        assert.equal(bookend.stream_id, 5);
         assert.equal(bookend.stream_name, "IceCream");
         assert.equal(bookend.subscribed, false);
         assert.equal(bookend.deactivated, false);
@@ -425,11 +431,13 @@ run_test("bookend", ({override}) => {
         list.update_trailing_bookend();
         assert.equal(stub.num_calls, 1);
         const bookend = stub.get_args(
+            "stream_id",
             "stream_name",
             "subscribed",
             "deactivated",
             "just_unsubscribed",
         );
+        assert.equal(bookend.stream_id, 5);
         assert.equal(bookend.stream_name, "IceCream");
         assert.equal(bookend.subscribed, false);
         assert.equal(bookend.deactivated, false);