Skip to content

Commit

Permalink
left_sidebar: Attach navigation Tippies to <li> elements.
Browse files Browse the repository at this point in the history 
This corrects a likely long-standing bug where nav tippies appear
over the navigation box. With the gridded DM rows having corrected
the placement of DM Tippies, this commit brings the nav Tippies in
league with those.
  • Loading branch information
@karlstolley @timabbott
karlstolley authored and timabbott committed Nov 2, 2023
1 parent 6784dee commit c56bd24
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions web/templates/left_sidebar.hbs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@
</div>
</div>
<ul id="left-sidebar-navigation-list" class="left-sidebar-navigation-list filters">
<li class="top_left_inbox top_left_row hidden-for-spectators">
<a href="#inbox" class="tippy-views-tooltip left-sidebar-navigation-label-container" data-tooltip-template-id="inbox-tooltip-template">
<li class="tippy-views-tooltip top_left_inbox top_left_row hidden-for-spectators" data-tooltip-template-id="inbox-tooltip-template">
<a href="#inbox" class="left-sidebar-navigation-label-container">
<span class="filter-icon">
<i class="zulip-icon zulip-icon-inbox" aria-hidden="true"></i>
</span>
Expand All @@ -60,8 +60,8 @@
</a>
<span class="arrow sidebar-menu-icon inbox-sidebar-menu-icon hidden-for-spectators"><i class="zulip-icon zulip-icon-more-vertical" aria-hidden="true"></i></span>
</li>
<li class="top_left_recent_view top_left_row">
<a href="#recent" class="tippy-views-tooltip left-sidebar-navigation-label-container" data-tooltip-template-id="recent-conversations-tooltip-template">
<li class="tippy-views-tooltip top_left_recent_view top_left_row" data-tooltip-template-id="recent-conversations-tooltip-template">
<a href="#recent" class="left-sidebar-navigation-label-container">
<span class="filter-icon">
<i class="zulip-icon zulip-icon-clock" aria-hidden="true"></i>
</span>
Expand All @@ -72,8 +72,8 @@
<i class="zulip-icon zulip-icon-more-vertical" aria-hidden="true"></i>
</span>
</li>
<li class="top_left_all_messages top_left_row">
<a href="#all_messages" class="home-link tippy-views-tooltip left-sidebar-navigation-label-container" data-tooltip-template-id="all-message-tooltip-template">
<li class="tippy-views-tooltip top_left_all_messages top_left_row" data-tooltip-template-id="all-message-tooltip-template">
<a href="#all_messages" class="home-link left-sidebar-navigation-label-container">
<span class="filter-icon">
<i class="zulip-icon zulip-icon-all-messages" aria-hidden="true"></i>
</span>
Expand Down Expand Up @@ -105,8 +105,8 @@
</a>
<span class="arrow sidebar-menu-icon starred-messages-sidebar-menu-icon"><i class="zulip-icon zulip-icon-more-vertical" aria-hidden="true"></i></span>
</li>
<li class="top_left_drafts top_left_row hidden-for-spectators">
<a href="#drafts" class="tippy-left-sidebar-tooltip left-sidebar-navigation-label-container" data-tooltip-template-id="drafts-tooltip-template">
<li class="tippy-left-sidebar-tooltip top_left_drafts top_left_row hidden-for-spectators" data-tooltip-template-id="drafts-tooltip-template">
<a href="#drafts" class="left-sidebar-navigation-label-container">
<span class="filter-icon">
<i class="zulip-icon zulip-icon-drafts" aria-hidden="true"></i>
</span>
Expand Down

0 comments on commit c56bd24

Please sign in to comment.