Make prefix/suffix be included conditionally instead of always. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of always. Added specs and simplified existing tests. Includes generated js from coffeescript 1.6.3.
|
Any chance to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
My use case is in a real-time app with expiring offers, but after ending I want to show the end time as '1 minute ago' or 'in less than 1 minute' when end time is in the future. The current codebase was always including the prefix and suffix which didn't make sense 'in less than 1 minute ago' :P This PR fixes this behaviour.
Looking at the repo history the code was once more conditional and this was changed to always include it, not sure why?
I've been able to simplify the tests, and added 2 more at the bottom to prove the formatting of the resulting text is correct.