Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readMe #455

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Updated readMe #455

merged 1 commit into from
Nov 23, 2023

Conversation

vomba
Copy link
Contributor

@vomba vomba commented Oct 16, 2023

  • Removed metricInterval, does not exist anymore.
  • Updated metricExporter to MetricReader.

@pragmaticivan
Copy link
Owner

Hi @vomba would you mind ammending your commit with conventional commit standard? https://www.conventionalcommits.org/en/v1.0.0/

I kinda need that to release new versions.

@vomba
Copy link
Contributor Author

vomba commented Oct 23, 2023

Is this good ? to be honest, i haven't used --amend before

@pragmaticivan pragmaticivan merged commit 1f46ee4 into pragmaticivan:main Nov 23, 2023
@vomba vomba deleted the patch-1 branch November 19, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants