Add panic handler for COFF execution #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for your excellent repository, it works amazing in my testing. However, for my use case I need to be able to 'catch' unexpected BOF crashes - something that's only possible from the current goroutine. As such, I needed to make a small adjustment to the library which I may as well contribute back! :)
This PR introduces a simple panic handler that propagates any unexpected errors (BOF crashes) upstream as output. This prevents the caller from crashing, and allows the error to be handled downstream if needed. The changes should not affect normal execution in any way.