Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Introduce floatwin/popupwin compatible layer #567

Closed
wants to merge 2 commits into from

Conversation

hrsh7th
Copy link
Collaborator

@hrsh7th hrsh7th commented Nov 19, 2019

This PR aims to discuss the PR #510.

TODO

  • Support fenced language highlighting (difficult...).
  • Switch output.vim to new implementation.

Please feedback the APIs and below points.

  • How to support let g:lsp_preview_float = 0.
  • How to support popup-win's border feature.
  • Currently implementation always usemarkdown syntax.

@hrsh7th hrsh7th mentioned this pull request Nov 19, 2019
@prabirshrestha
Copy link
Owner

Would be also good to have borders for neovim. Can be in different PR neovim/neovim#9718 (comment)

@clason
Copy link
Contributor

clason commented Dec 31, 2019

@prabirshrestha
Copy link
Owner

Thanks for sending this PR.

Let us move this to top level utils folder instead of ui/vim. I will be working on refactoring ui/vim/vim.vim into smaller utils. I want to slowly get rid of the ui folder.

Here are some of the api name changes we should do.

let l:floatwin = lsp#utils#floatwin#new({ ... })
call l:floatwin.show(screenpos, lsp#utils#normalize_markup_content(content))
call l:floatwin.hide()
call l:floatwin.enter() " should this be called focus()?
call l:floatwin.is_visible()

call lsp#utils#floatwin#calcaulate_height(contents)
call lsp#utils#floatwin#calcaulate_width(contents)
call lsp#utils#floatwin#screenpos(line, col, bufnr) " do we need bufnr?

@prabirshrestha
Copy link
Owner

@hrsh7th any updates on this? currently it has merge conflicts.

@hrsh7th
Copy link
Collaborator Author

hrsh7th commented May 11, 2020

Sorry, I have forgotten this PR.

Hm... PR has a problem that is missing preview-window feature.

Anyway, I will solve conflicts.

@prabirshrestha
Copy link
Owner

let us continue the discussion at vim-jp/vital.vim#747 and vim-jp/vital.vim#748.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants