Fix up + improve CI test reporting workflow #30543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Nov 8, 2024
Comment on lines
+24
to
+28
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: ${{ github.event.workflow_run.repository.full_name }} | ||
| ref: ${{ github.event.workflow_run.head_sha }} |
There was a problem hiding this comment.
Why is this checking out the source? Is this required for anything?
There was a problem hiding this comment.
Yeah, it's required by the test reporter when not using artifacts, for some reason. See for example: https://github.com/smoogipoo/osu/actions/runs/11724637370/job/32659046284
bdach
approved these changes
Nov 8, 2024
bdach
added a commit
to bdach/osu-framework
that referenced
this pull request
Nov 12, 2024
Carbon copy of ppy/osu#30543.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issued a deprecation warning for
actions/upload-artifact@v3, so we upgraded to v4. This now uses Azure Blob Storage with SAS, which thedorny/test-reporteraction seems to not be compatible with likely because it passes theAuthorizationheader that is no longer required.To fix this I've rewritten the workflow so that it uses
actions/download-artifactto download the results, with the test reporter now running on local files.In the process I've refactored it to run once per execution which comes with the benefit of deduping annotations.
See example: https://github.com/smoogipoo/osu/actions/runs/11735233749/job/32693913350