Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to hide breaks from timeline #30505

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

peppy
Copy link
Member

@peppy peppy commented Nov 5, 2024

This was another IRL request from a mapper / team member. The rationale here is that it can be very annoying to map with break time enabled if you have a large gap in the beatmap you are trying to fill with hitobjects, as you are placing objects on top of a very gray area:

osu.2024-11-05.at.04.06.40.mp4

Open to other suggestions if this won't fly. One argument would be that "if you disable this you might be unaware of breaks existing at all and forget to turn it back on", although given that it's a very explicit toggle maybe that's on the user.

This was another IRL request from a mapper / team member. The rationale
here is that it can be very annoying to map with break time enabled if
you have a large gap in the beatmap you are trying to fill with
hitobjects, as you are placing objects on top of a very gray area.
@cl8n
Copy link
Member

cl8n commented Nov 5, 2024

maybe the uncommitted blueprint could still update break times, so they don't overlap with new mapping

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objection

@bdach
Copy link
Collaborator

bdach commented Nov 5, 2024

maybe the uncommitted blueprint could still update break times, so they don't overlap with new mapping

not very simple to make happen, so if this works for people i'm fine with this.

@peppy
Copy link
Member Author

peppy commented Nov 6, 2024

maybe the uncommitted blueprint could still update break times, so they don't overlap with new mapping

This would be optimal I think, but yeah it's not a 5 minute change.

Given that break placement is a mostly automatic thing I think the ability to just not see them is probably fine. Maybe the fact that at least one person is annoyed by them means they are also too prominent visually on the display.

@bdach bdach merged commit 2699ebb into ppy:master Nov 6, 2024
13 checks passed
@peppy peppy deleted the editor-hide-breaks branch November 7, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants