Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep editor sidebars expanded by default #30387

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Oct 22, 2024

They will not only contract if the user chooses to have them contract (new setting in the View menu) or if the game isn't wide enough to allow full interaction with the playfield while they are expanded.

Addresses #28970.

They will not only contract if the user chooses to have them contract
(new setting in the `View` menu) or if the game isn't wide enough to
allow full interaction with the playfield while they are expanded.

Addressess ppy#28970.
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taiko says no to this change in this form:

osu_2024-10-22_13-27-36

@peppy
Copy link
Member Author

peppy commented Oct 25, 2024

@bdach pushed a fix for taiko, see what you think.

@bdach bdach self-requested a review October 25, 2024 17:36
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry a bit that this is gonna bring back all the "claustrophobia" comments but I suppose this is behind a toggle so maybe worth a go

@bdach bdach merged commit b72a50b into ppy:master Oct 25, 2024
13 checks passed
@peppy peppy deleted the editor-sidebars-always-expanded branch October 31, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants