Use minimum enclosing circle as selection centre for scale and rotate #29938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
requested changes
Sep 20, 2024
osu.Game/Screens/Edit/Compose/Components/SelectionBoxRotationHandle.cs
Outdated
Show resolved
Hide resolved
bdach
reviewed
Sep 24, 2024
peppy
previously approved these changes
Sep 27, 2024
bdach
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29567
Uses Welzl's algorithm to efficiently compute the minimum enclosing circle to use as the centre of selection when doing scale or rotate operations. It's a recursive algorithm with max depth equal to the number of points.
As I also explained in the issue, I think the minimum enclosing circle centre best represents our expectations when considering a selection centre. Also it's able to take into account the shapes of sliders unlike a center of mass calculation (as in stable).
In the issue there is also the idea of visually indicating the centre point while doing the operation, kind of like a gizmo. Do we want this? If so, where in the drawable tree?