Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several issues in interactions between playfield-altering mods and the replay analysis feature #29841

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Fix several issues in interactions between playfield-altering mods and the replay analysis feature #29841

merged 3 commits into from
Sep 12, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Sep 11, 2024

Treat this as an RFC though because I'm not really all that happy with the code.

mods master this PR
FL osu_2024-09-11_15-56-22 osu_2024-09-11_16-10-14
BL osu_2024-09-11_15-56-52 osu_2024-09-11_16-10-32
BU osu_2024-09-11_15-57-12 osu_2024-09-11_16-10-49
BU, FL osu_2024-09-11_16-01-04 osu_2024-09-11_16-11-05
BR osu_2024-09-11_16-03-45 osu_2024-09-11_16-11-26

Of note:

  • b78ef81 fixes a regression of visuals when Bubbles and Flashlight are both active (inadvertently caused by yours truly)
  • 4a39873 causes the playfield to shift slightly but I'm not sure how to avoid it. It's probably for the better anyhow since it appears it brings more of the playfield onto the screen?

smoogipoo
smoogipoo approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably alright. Not sure about using NegativeInfinity but I suppose it shouldn't cause any problems... The alternative I would suggest is float.MinValue - 1

@peppy peppy merged commit a836520 into ppy:master Sep 12, 2024
11 of 13 checks passed
@bdach bdach deleted the replay-analysis-mod-woes branch September 12, 2024 05:47
@JacksonChen666 JacksonChen666 mentioned this pull request Sep 12, 2024
Closed
@ssz7-ch2 ssz7-ch2 mentioned this pull request Oct 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
area:mods area:replay ruleset/osu! size/S type:cosmetic
Projects
None yet
Milestone
No milestone
3 participants
@bdach @peppy @smoogipoo