Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timing points being blocked by buttons in the editor #29766

Merged
merged 6 commits into from
Sep 8, 2024

Conversation

SchiavoAnto
Copy link
Contributor

Would fix #29761.

@bdach
Copy link
Collaborator

bdach commented Sep 8, 2024

Sound idea but pretty terrible execution. The map background shouldn't be peering behind the buttons like it currently is.

osu_2024-09-08_13-43-27

If you can figure out how to give that a background that matches the pieces around it then I think we have something we can ship. Not sure what background colour to give it, maybe try something like Background2 from OverlayColourProvider.

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

@pull-request-size pull-request-size bot added size/M and removed size/XS labels Sep 8, 2024
@SchiavoAnto
Copy link
Contributor Author

I successfully added a background color, Background2 as you suggested. Tried Background6 too to be similar to the settings section on the right but thought it looked better with the one you suggested.
Let me know if there are other things to change.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 8, 2024
@bdach
Copy link
Collaborator

bdach commented Sep 8, 2024

@SchiavoAnto I've made a few adjustments here. Please ask if something is unclear.

@peppy requesting double-check for visuals at the least:

osu_2024-09-08_16-31-34

@bdach bdach requested a review from peppy September 8, 2024 14:32
@bdach bdach changed the title Fixed timing points being blocked by buttons in the editor Fix timing points being blocked by buttons in the editor Sep 8, 2024
@peppy
Copy link
Member

peppy commented Sep 8, 2024

Seems fine I think.

@bdach bdach merged commit f0e2b80 into ppy:master Sep 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select closest to current time button will block some information
4 participants