-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide scroll speed changes in std and ctb editor #29448
Conversation
Yeah I dunno. The conditional seems generally sane, but I'm not sure how to fix the test aside from just... fixing the test itself to not use a The fact that instantiating a |
They were being drawn far offscreen because the width of the kiai multiplied with the X coordinate of the scroll speed vis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit concerned about the scope creep in polluting Ruleset
, but I suppose I'm fine with this for the time being.
That's why I was expecting more discussion to happen here rather than a quick merge. I think we'll need to do a very API-breaking pass on |
closes #29336
Test is broken because you cant make a
DrawableRuleset
of aTestBeatmap
. Is there a better way to extract ruleset information from the beatmap?