Automatically use in-game language for wiki pages #29401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Just fetch the in-game language (using
load()) fromOsuGameBase.CurrentLanguagewhen loading wiki pages.Since we detect the language code in
values[0]first, it works for links already containing a language code (like https://osu.ppy.sh/wiki/zh/Client/Installation).And chances are that we get:
Then we can use the in-game language as an argument of the request to get the language-specific page.
Known Issues
We cannot get the
Sitemappage, even before this PR. This is an issue that should be fixed somehow in the future (on osu!web?).