Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to hide song progress time/text #29372

Merged
merged 3 commits into from
Aug 12, 2024

Fix one more inspectcode warning

fed5b9d
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Add option to hide song progress time/text #29372

Fix one more inspectcode warning
fed5b9d
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, MultiThreaded) failed Aug 12, 2024 in 1s

10340 passed, 2 failed and 74 skipped

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

10416 tests were completed in 2956s with 10340 passed, 2 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Rulesets.Osu.Tests.TestSceneSpinnerRotation 9✅ 1❌ 21s
osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn 33✅ 1❌ 7s

❌ osu.Game.Rulesets.Osu.Tests.TestSceneSpinnerRotation

✅ TestConstructor
✅ TestRotationDirection(False)
✅ TestRotationDirection(True)
✅ TestSpinnerCompleteBonusRewinding
✅ TestSpinnerMiddleRewindingRotation
✅ TestSpinnerNormalBonusRewinding
✅ TestSpinnerRewindingRotation
❌ TestSpinPerMinuteOnRewind
	spm still valid: Expected: 477.64521211249644d +/- 1.0d
	  But was:  463.36643111004287d
	  Off by:   14.27878100245357d
	
✅ TestSpinUnaffectedByClockRate(0.5d)
✅ TestSpinUnaffectedByClockRate(2.0d)

❌ osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn

✅ TestConstructor
✅ TestConstructor
✅ TestLeadInProducesCorrectStartTime(1000,0)
✅ TestLeadInProducesCorrectStartTime(1000,0)
✅ TestLeadInProducesCorrectStartTime(10000,-7830.0d)
✅ TestLeadInProducesCorrectStartTime(10000,-7830.0d)
❌ TestLeadInProducesCorrectStartTime(2000,0)
	check first frame time: Expected: 0.0d +/- 100.0d
	  But was:  101.8985d
	  Off by:   -101.8985d
	
✅ TestLeadInProducesCorrectStartTime(2000,0)
✅ TestLeadInProducesCorrectStartTime(3000,-830.0d)
✅ TestLeadInProducesCorrectStartTime(3000,-830.0d)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,True)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-1000,-1000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-1000,-1000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-10000,-10000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-10000,-10000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(0,0)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(0,0)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(1000,0)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(1000,0)

Annotations

Check failure on line 0 in TestResults-Windows-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.TestSceneSpinnerRotation ► TestSpinPerMinuteOnRewind 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  spm still valid: Expected: 477.64521211249644d +/- 1.0d
    But was:  463.36643111004287d
    Off by:   14.27878100245357d
Raw output 
spm still valid: Expected: 477.64521211249644d +/- 1.0d
  But was:  463.36643111004287d
  Off by:   14.27878100245357d

   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()

Check failure on line 0 in TestResults-Windows-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn ► TestLeadInProducesCorrectStartTime(2000,0) 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  check first frame time: Expected: 0.0d +/- 100.0d
    But was:  101.8985d
    Off by:   -101.8985d
Raw output 
check first frame time: Expected: 0.0d +/- 100.0d
  But was:  101.8985d
  Off by:   -101.8985d

   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()
View more details on GitHub Actions