Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pause input handling in osu! not working like stable #29250

Merged
merged 8 commits into from
Aug 5, 2024

Replace try-finally with return

20b8905
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix pause input handling in osu! not working like stable #29250

Replace try-finally with return
20b8905
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, MultiThreaded) failed Aug 5, 2024 in 1s

10286 passed, 2 failed and 74 skipped

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

10362 tests were completed in 2878s with 10286 passed, 2 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation 89✅ 1❌ 129s
osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations 11✅ 1❌ 20s

❌ osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation

❌ TestAttemptPlayBeatmapMissingFails
	System.IO.IOException : The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\of-test-headless\TestSceneScreenNavigation-0bb5c2f2-aecd-4293-9543-7f17b0b1ef0e\files\a\a3\a3cdca78c8435a097b6116f17796e4c8415e302475e30ecf73da307553c43645' because it is being used by another process.
✅ TestAttemptPlayBeatmapMissingFails
✅ TestAttemptPlayBeatmapWrongHashFails
✅ TestAttemptPlayBeatmapWrongHashFails
✅ TestBeatmapListingLinkSearchOnInitialOpen
✅ TestBeatmapListingLinkSearchOnInitialOpen
✅ TestBeatmapOptionsInput
✅ TestBeatmapOptionsInput
✅ TestConfirmationRequiredToDiscardPlaylist(False)
✅ TestConfirmationRequiredToDiscardPlaylist(False)
✅ TestConfirmationRequiredToDiscardPlaylist(True)
✅ TestConfirmationRequiredToDiscardPlaylist(True)
✅ TestConstructor
✅ TestConstructor
✅ TestDeleteAllScoresAfterPlaying
✅ TestDeleteAllScoresAfterPlaying
✅ TestDeleteScoreAfterPlaying
✅ TestDeleteScoreAfterPlaying
✅ TestExitGameFromSongSelect
✅ TestExitGameFromSongSelect
✅ TestExitImmediatelyAfterCompletion
✅ TestExitImmediatelyAfterCompletion
✅ TestExitMultiWithBackButton
✅ TestExitMultiWithBackButton
✅ TestExitMultiWithEscape
✅ TestExitMultiWithEscape
✅ TestExitSongSelectAndImmediatelyClickLogo
✅ TestExitSongSelectAndImmediatelyClickLogo
✅ TestExitSongSelectWithClick
✅ TestExitSongSelectWithClick
✅ TestExitSongSelectWithEscape
✅ TestExitSongSelectWithEscape
✅ TestExitWithHoldDisabled
✅ TestExitWithHoldDisabled
✅ TestExitWithOperationInProgress
✅ TestExitWithOperationInProgress
✅ TestFeaturedArtistDisclaimerDialog
✅ TestFeaturedArtistDisclaimerDialog
✅ TestForceExitWithOperationInProgress
✅ TestForceExitWithOperationInProgress
✅ TestMainOverlaysClosesNotificationOverlay
✅ TestMainOverlaysClosesNotificationOverlay
✅ TestMainOverlaysClosesSettingsOverlay
✅ TestMainOverlaysClosesSettingsOverlay
✅ TestMenuMakesMusic
✅ TestMenuMakesMusic
✅ TestModSelectInput
✅ TestModSelectInput
✅ TestModsResetOnEnteringMultiplayer
✅ TestModsResetOnEnteringMultiplayer
✅ TestOpenModSelectOverlayUsingAction
✅ TestOpenModSelectOverlayUsingAction
✅ TestOpenOptionsAndExitWithEscape
✅ TestOpenOptionsAndExitWithEscape
✅ TestOverlayClosing
✅ TestOverlayClosing
✅ TestPresentBeatmapAfterDeletion
✅ TestPresentBeatmapAfterDeletion
✅ TestPushMatchSubScreenAndPressBackButtonImmediately
✅ TestPushMatchSubScreenAndPressBackButtonImmediately
✅ TestPushSongSelectAndPressBackButtonImmediately
✅ TestPushSongSelectAndPressBackButtonImmediately
✅ TestQuickSkinEditorDoesntNukeSkin
✅ TestQuickSkinEditorDoesntNukeSkin
✅ TestRetryCountIncrements
✅ TestRetryCountIncrements
✅ TestRetryFromResults
✅ TestRetryFromResults
✅ TestRetryImmediatelyAfterCompletion
✅ TestRetryImmediatelyAfterCompletion
✅ TestSettingsViaHotkeyFromMainMenu
✅ TestSettingsViaHotkeyFromMainMenu
✅ TestShowMedalAtResults
✅ TestShowMedalAtResults
✅ TestSongContinuesAfterExitPlayer(False)
✅ TestSongContinuesAfterExitPlayer(False)
✅ TestSongContinuesAfterExitPlayer(True)
✅ TestSongContinuesAfterExitPlayer(True)
✅ TestSongSelectBackActionHandling
✅ TestSongSelectBackActionHandling
✅ TestSongSelectScrollHandling
✅ TestSongSelectScrollHandling
✅ TestToolbarHiddenByUser
✅ TestToolbarHiddenByUser
✅ TestTouchScreenDetectionAtSongSelect
✅ TestTouchScreenDetectionAtSongSelect
✅ TestTouchScreenDetectionInGame
✅ TestTouchScreenDetectionInGame
✅ TestWaitForNextTrackInMenu
✅ TestWaitForNextTrackInMenu

❌ osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations

✅ TestBestRulesetIsRecommended
✅ TestBestRulesetIsRecommended
✅ TestConstructor
✅ TestConstructor
❌ TestCorrectStarRatingIsUsed
	"recommended beatmap displayed" timed out
✅ TestCorrectStarRatingIsUsed
✅ TestCurrentRulesetIsRecommended
✅ TestCurrentRulesetIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestSecondBestRulesetIsRecommended
✅ TestSecondBestRulesetIsRecommended

Annotations

Check failure on line 276 in osu.Game.Tests/Visual/Navigation/TestSceneScreenNavigation.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation ► TestAttemptPlayBeatmapMissingFails

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  System.IO.IOException : The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\of-test-headless\TestSceneScreenNavigation-0bb5c2f2-aecd-4293-9543-7f17b0b1ef0e\files\a\a3\a3cdca78c8435a097b6116f17796e4c8415e302475e30ecf73da307553c43645' because it is being used by another process.
Raw output
System.IO.IOException : The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\of-test-headless\TestSceneScreenNavigation-0bb5c2f2-aecd-4293-9543-7f17b0b1ef0e\files\a\a3\a3cdca78c8435a097b6116f17796e4c8415e302475e30ecf73da307553c43645' because it is being used by another process.
   at System.IO.FileSystem.DeleteFile(String fullPath)
   at osu.Framework.Platform.NativeStorage.Delete(String path)
   at osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation.<>c__DisplayClass11_0.<TestAttemptPlayBeatmapMissingFails>b__4() in D:\a\osu\osu\osu.Game.Tests\Visual\Navigation\TestSceneScreenNavigation.cs:line 276
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.<.ctor>b__1_0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations ► TestCorrectStarRatingIsUsed

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  "recommended beatmap displayed" timed out
Raw output
"recommended beatmap displayed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)