Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix daily challenge background clipping when settings/notifications is opened #29127

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Fix daily challenge background clipping when settings/notifications is opened #29127

merged 1 commit into from
Jul 29, 2024

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Jul 27, 2024

Same as OnlinePlayScreen:

osu/osu.Game/Screens/OnlinePlay/OnlinePlayScreen.cs

Line 55 in 788b704

Padding = new MarginPadding { Horizontal = -HORIZONTAL_OVERFLOW_PADDING };

@bdach bdach self-requested a review July 29, 2024 08:22
@bdach bdach merged commit aa7f6f8 into ppy:master Jul 29, 2024
9 of 13 checks passed
@Joehuu Joehuu deleted the add-negative-horizontal-padding-daily branch July 31, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
area:daily-challenge size/XS type:cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joehuu @bdach