Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve score breakdown on daily challenge #29108

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Improve score breakdown on daily challenge #29108

merged 3 commits into from
Jul 26, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jul 26, 2024

  • Add tooltips showing counts and ranges for each bar
  • Highlight bar which user's score belongs to
2024-07-26.14-34-20.mp4

osu_2024-07-26_14-36-06

The implementation is a bit dodgy (parasites off the leaderboard) but maybe fine?

@bdach bdach self-assigned this Jul 26, 2024
@bdach bdach added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Jul 26, 2024
@peppy peppy self-requested a review July 26, 2024 13:28
@peppy peppy merged commit 4fa6a19 into ppy:master Jul 26, 2024
10 of 13 checks passed
@bdach bdach deleted the daily-challenge/better-breakdown branch July 26, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees

@bdach bdach

Labels
area:daily-challenge next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/L type:cosmetic
Projects
osu! client development focus
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdach @peppy