Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for the volume of ruleset elements (hitsounds) #28733

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

leocb
Copy link

@leocb leocb commented Jul 4, 2024

Hi! First time contributing here!

This PR adds the option to mute only hitsounds.

The setting is available on the main menu and on the play "quick" menu

I followed what was already in place for the mute mod and, while this aims to only mute hitsounds, AFAIK my implementation will mute any sounds coming from the ruleset drawable, I don't know if this impacts other desired sounds, if this is acceptable or if the name should be changed from "hitsounds" to something else to better reflect this "ruleset mute".

@peppy
Copy link
Member

peppy commented Jul 4, 2024

Thanks for your contribution.

I'd say the more desired behaviour is to have volume control for hitsounds, rather than a toggle.

@leocb
Copy link
Author

leocb commented Jul 4, 2024

This is a toggle as it's being applied as a multiplier on top of the effects volume, having a slider would make 100% be the same volume as the current effects volume, which may be confusing.
I don't know if it can be easily separated into another slider without messing with framework too.

@bdach
Copy link
Collaborator

bdach commented Jul 4, 2024

Also against this feature in its current form.

I don't know if it can be easily separated into another slider without messing with framework too.

Easiest path towards that would probably be to put gameplay samples on a separate mixer. Which is something we may want to do at some point anyway, but definitely will not be a 20-line diff like this is.

@peppy
Copy link
Member

peppy commented Jul 4, 2024

Easiest path towards that would probably be to put gameplay samples on a separate mixer. Which is something we may want to do at some point anyway, but definitely will not be a 20-line diff like this is.

Failing this, exposing an audio adjustment for the gameplay/ruleset audio container should be relatively simple.

leocb added 2 commits July 5, 2024 02:33
Add Volume slider for gameplay sounds
Modify ruleset container to AudioMixerContainer
Swap Music and effects sliders
@leocb
Copy link
Author

leocb commented Jul 5, 2024

I made some modifications in framework to allow mixers to have their own volume, now this PR depends on this one: ppy/osu-framework#6326
I removed the option from the play "quick" settings
The ruleset container was changed to AudioMixerContainer and now has it's own mixer separate from the UI sfx
I added a slider in the settings for the gameplay sounds volume and called it Gameplay feel free to suggest other names that better reflect what this does

@leocb leocb changed the title Add settings option to mute only hitsounds Add setting for the volume of ruleset elements (hitsounds) Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants