-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting for the volume of ruleset elements (hitsounds) #28733
base: master
Are you sure you want to change the base?
Conversation
Thanks for your contribution. I'd say the more desired behaviour is to have volume control for hitsounds, rather than a toggle. |
This is a toggle as it's being applied as a multiplier on top of the effects volume, having a slider would make 100% be the same volume as the current effects volume, which may be confusing. |
Also against this feature in its current form.
Easiest path towards that would probably be to put gameplay samples on a separate mixer. Which is something we may want to do at some point anyway, but definitely will not be a 20-line diff like this is. |
Failing this, exposing an audio adjustment for the gameplay/ruleset audio container should be relatively simple. |
Add Volume slider for gameplay sounds Modify ruleset container to AudioMixerContainer Swap Music and effects sliders
I made some modifications in framework to allow mixers to have their own volume, now this PR depends on this one: ppy/osu-framework#6326 |
Hi! First time contributing here!
This PR adds the option to mute only hitsounds.
The setting is available on the main menu and on the play "quick" menu
I followed what was already in place for the mute mod and, while this aims to only mute hitsounds, AFAIK my implementation will mute any sounds coming from the ruleset drawable, I don't know if this impacts other desired sounds, if this is acceptable or if the name should be changed from "hitsounds" to something else to better reflect this "ruleset mute".