-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pp and playtime to the UserRankPanel
#27147
base: master
Are you sure you want to change the base?
Conversation
I'm not sure how to feel about the pp count being added where you have it given I had been just working on something to show pp count after every play a few days ago. There's also #27128 and #27107 which touch the same places. Way too crowded up in here. |
I wouldn't say any of those PRs are mutually exclusive with this one, and imo the only one that's even related to this one is #27128 since #27156 is a notification type of thing while this is always available data and #27107 is in the completely different place (user overlay) and doesn't affect I don't think this PR is high priority in any way though so it can stay blocked until the statistics watching refactoring is in |
I agree that the two aren't mutually exclusive. |
Spacing on this looks a bit dodge: The total playtime is a touch long there. And it's not exactly just a case of outlandish data either, we have actual users that have played that much. |
I've noticed the rank can overflow on 7+ digits as well - I'm not sure how to go about fixing it, making fonts smaller is an obvious solution, but profile data classes already have a small option and adding something like medium sounds ugly and making user rank panel wider will probably need login panel design adjustments |
Making wider is probably easiest. I'm not sure that panel needs any design adjustment other than "make wider". Layout seems pretty simple there. |
I'd argue shit is all over the place. There's 4 different font sizes on the panel. the headers are the same colour while the content beneath the headers differs in colour. "pp" is lower case. everything feels wonky, and the panel feels like it's going to topple over to the right. @arflyte please fix/advise. |
I would prefer playtime in hours, it's much more readable than days |
It matches the profile overlay. If it's to change it should change in both places. And web. Chances are it'll have hours as a tooltip anyhow (because profile overlay does). |
Relevant figma design (not matching 100%, was taken as inspiration): https://www.figma.com/file/ocltATjJqWQZBravhPuqjB/UI%2FPlayer-Card?type=design&node-id=42-1189&mode=design&t=lr0a8PR9pPC0mCUK-0
Something I should've done in the first PR honestly. I'd say this is as much info as this panel can fit without looking messy