Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approximate amount of effective misses using combo #15086

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Approximate amount of effective misses using combo #15086

merged 4 commits into from
Oct 18, 2021

Conversation

stanriders
Copy link
Member

@stanriders stanriders requested a review from a team October 13, 2021 17:18
@smoogipoo
Copy link
Contributor

smoogipoo commented Oct 16, 2021 •
edited
Loading

This score causes NaN values: https://osu.ppy.sh/scores/osu/2917569263. The following osu-tools args repro it:

simulate osu 168031 -c 1 -X 623 -M 0 -G 0

@stanriders
Copy link
Member Author

Huh, seems like effectiveMissCount can be bigger than totalHits because it's being derived from combo. I think clamping it to totalHits max should be good enough since its pretty much an edge case

@smoogipoo
Copy link
Contributor

Spreadsheet of top PP changes as a result.

If there's no pushback, I'll merge with approvals from the PP committee.

@smoogipoo smoogipoo requested a review from a team October 17, 2021 02:30
@smoogipoo smoogipoo merged commit 43c2e9b into ppy:master Oct 18, 2021
@stanriders stanriders deleted the effective-miss-count branch November 9, 2021 17:02
@smoogipoo smoogipoo mentioned this pull request Jan 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apollo-dw apollo-dw apollo-dw approved these changes

@MBmasher MBmasher MBmasher approved these changes

@emu1337 emu1337 emu1337 approved these changes

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
area:difficulty ruleset/osu! size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stanriders @smoogipoo @emu1337 @MBmasher @apollo-dw @bdach