-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix instant spinners giving insane amounts of strain #15009
Conversation
osu.Game.Rulesets.Osu/Difficulty/Preprocessing/OsuDifficultyHitObject.cs
Outdated
Show resolved
Hide resolved
the modified block of code - as far as i can gather - is trying to calculate an angle between three subsequent positions. would it not make more sense to not run any of it if any of the three objects involved was a spinner? i'm especially thinking about |
Yeah that makes sense |
osu.Game.Rulesets.Osu/Difficulty/Preprocessing/OsuDifficultyHitObject.cs
Outdated
Show resolved
Hide resolved
…tObject.cs Co-authored-by: Liam DeVoe <[email protected]>
It was mentioned on discord that this still leaves room for StrainTime to give speed PP. Maybe a better approach is to filter out spinners from OsuDifficultyCalculator so they're fully excluded from all skills. Seems all the skills were trying (unsuccessfully) to filter them out anyway. |
Spreadsheet of SR changes (PP changes not listed). Looks good to me. |
Fixes maps such as https://osu.ppy.sh/beatmapsets/814850#osu/1901200 (9.98* -> 6.54*)
https://osu.ppy.sh/beatmapsets/388378#osu/847257 (13.88* -> 6.20*)
Should not affect normal maps, even extremes such as https://osu.ppy.sh/beatmapsets/132#osu/296