Clamp comboBasedMissCount

ppy · Oct 16, 2021 · ccaac97 · ccaac97
1 parent c8d99e6
commit ccaac97
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs b/osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs
@@ -265,6 +265,9 @@ private int calculateEffectiveMissCount()
                     comboBasedMissCount = fullComboThreshold / Math.Max(1.0, scoreMaxCombo);
             }
 
+            // we're clamping misscount because since its derived from combo it can be higher than total hits and that breaks some calculations
+            comboBasedMissCount = Math.Min(comboBasedMissCount, totalHits);
+
             return Math.Max(countMiss, (int)Math.Floor(comboBasedMissCount));
         }