Skip to content

Commit

Permalink
Merge pull request #13967 from nekodex/new-select-sounds
Browse files Browse the repository at this point in the history
Add new 'soft' select sound variant and use it in some places
  • Loading branch information
peppy authored Jul 22, 2021
2 parents 8b12021 + 0cfa8f0 commit 29ffae4
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 7 deletions.
2 changes: 1 addition & 1 deletion osu.Android.props
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
<Reference Include="Java.Interop" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="ppy.osu.Game.Resources" Version="2021.706.0" />
<PackageReference Include="ppy.osu.Game.Resources" Version="2021.722.0" />
<PackageReference Include="ppy.osu.Framework.Android" Version="2021.721.0" />
</ItemGroup>
<ItemGroup Label="Transitive Dependencies">
Expand Down
3 changes: 3 additions & 0 deletions osu.Game/Graphics/UserInterface/HoverSampleSet.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ public enum HoverSampleSet
[Description("default")]
Default,

[Description("soft")]
Soft,

[Description("button")]
Button,

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using osu.Framework.Graphics.Sprites;
using osu.Framework.Graphics.UserInterface;
using osu.Game.Graphics.Sprites;
using osu.Game.Graphics.UserInterface;

namespace osu.Game.Graphics.UserInterfaceV2
{
Expand All @@ -25,9 +26,13 @@ private void load()
Flow.AutoSizeAxes = Axes.X;
Flow.Height = OsuDirectorySelector.ITEM_HEIGHT;

AddInternal(new Background
AddRangeInternal(new Drawable[]
{
Depth = 1
new Background
{
Depth = 1
},
new HoverClickSounds(HoverSampleSet.Soft)
});
}

Expand Down
9 changes: 7 additions & 2 deletions osu.Game/Graphics/UserInterfaceV2/OsuFileSelector.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using osu.Framework.Graphics.UserInterface;
using osu.Game.Graphics.Containers;
using osu.Game.Graphics.Sprites;
using osu.Game.Graphics.UserInterface;

namespace osu.Game.Graphics.UserInterfaceV2
{
Expand Down Expand Up @@ -50,9 +51,13 @@ private void load()
Flow.AutoSizeAxes = Axes.X;
Flow.Height = OsuDirectorySelector.ITEM_HEIGHT;

AddInternal(new OsuDirectorySelectorDirectory.Background
AddRangeInternal(new Drawable[]
{
Depth = 1
new OsuDirectorySelectorDirectory.Background
{
Depth = 1
},
new HoverClickSounds(HoverSampleSet.Soft)
});
}

Expand Down
2 changes: 2 additions & 0 deletions osu.Game/Screens/Edit/EditorTable.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using osu.Game.Graphics;
using osu.Game.Graphics.Containers;
using osu.Game.Graphics.Sprites;
using osu.Game.Graphics.UserInterface;
using osu.Game.Overlays;
using osuTK.Graphics;

Expand Down Expand Up @@ -64,6 +65,7 @@ public class RowBackground : OsuClickableContainer
private EditorClock clock { get; set; }

public RowBackground(object item)
: base(HoverSampleSet.Soft)
{
Item = item;

Expand Down
2 changes: 1 addition & 1 deletion osu.Game/osu.Game.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
</PackageReference>
<PackageReference Include="Realm" Version="10.3.0" />
<PackageReference Include="ppy.osu.Framework" Version="2021.721.0" />
<PackageReference Include="ppy.osu.Game.Resources" Version="2021.706.0" />
<PackageReference Include="ppy.osu.Game.Resources" Version="2021.722.0" />
<PackageReference Include="Sentry" Version="3.6.0" />
<PackageReference Include="SharpCompress" Version="0.28.3" />
<PackageReference Include="NUnit" Version="3.13.2" />
Expand Down
2 changes: 1 addition & 1 deletion osu.iOS.props
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
</ItemGroup>
<ItemGroup Label="Package References">
<PackageReference Include="ppy.osu.Framework.iOS" Version="2021.721.0" />
<PackageReference Include="ppy.osu.Game.Resources" Version="2021.706.0" />
<PackageReference Include="ppy.osu.Game.Resources" Version="2021.722.0" />
</ItemGroup>
<!-- See https://github.com/dotnet/runtime/issues/35988 (can be removed after Xamarin uses net5.0 / net6.0) -->
<PropertyGroup>
Expand Down

0 comments on commit 29ffae4

Please sign in to comment.