Factor window scale in UserInputManager.mouseOutsideAllDisplays
#6432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mouse position is in pixel/client coordinates, while window and displays positions are in window coordinates.
Proof of coordinate spaces for display position (on a 3456x2234 macbook):
(Image taken from https://discord.com/channels/188630481301012481/188630652340404224/1308162379045011506)
We should probably have
IWindow.ClientToDisplay(Vector2)
that takes in a client (game screen space) vector and converts it to display coordinates. Would the need forISDLWindow
type checks from this code.