Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error triggered in label step execution not being logged #6421

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Nov 11, 2024

When executing a group of steps by clicking on the label, if a step fails, it does not get logged. Fix is pretty simple, don't need to waste my breath. I've also made the error message consistent with this.

@pull-request-size pull-request-size bot added size/S and removed size/L labels Nov 12, 2024
@bdach bdach self-requested a review November 12, 2024 10:20
@bdach bdach merged commit cef5432 into ppy:master Nov 12, 2024
13 checks passed
@frenzibyte frenzibyte deleted the fix-test-error-logging branch November 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants