Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CachedModelDependencyContainer to cache models with non-bindable fields #6416

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Nov 11, 2024

This container is very strict as to what sort of shape the model it contains should have, and rightfully so because it exposes a "shadow" model to the hierarchy so it can't ensure non-bindable data remains consistent.

But my current path for multiplayer is to remove these bindables bit by bit so as to not generate gigantic PRs, but this conflicts with the shape this container expects. At the end of it all, I hope to remove this container from multiplayer entirely.

So I've made it a bit more lenient by removing the static ctor and safeguarding for non-bindable members.

@peppy peppy merged commit b2ee73e into ppy:master Nov 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants