Allow CachedModelDependencyContainer
to cache models with non-bindable fields
#6416
+34
−155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This container is very strict as to what sort of shape the model it contains should have, and rightfully so because it exposes a "shadow" model to the hierarchy so it can't ensure non-bindable data remains consistent.
But my current path for multiplayer is to remove these bindables bit by bit so as to not generate gigantic PRs, but this conflicts with the shape this container expects. At the end of it all, I hope to remove this container from multiplayer entirely.
So I've made it a bit more lenient by removing the static ctor and safeguarding for non-bindable members.