fix(lfs-detection): take into account files without patch

[davidlj95]

Description

Fix #135 issue with PDF files.

Issue

For PDF files, seems that the patch field from the PR list files API is not there. Therefore, the check to see if it is stored in LFS or not fails

lfs-warning/src/index.ts

Lines 53 to 55 in 5d972cf

	const isStoredInLFS = Boolean(
	file.patch?.includes('version https://git-lfs.github.com/spec/v1')
	);

Proposed solution

Use the content field from the get blob API call for those files without patch. If file contents (base64 encoded, as per docs) start with the Git LFS usual file contents (version https://git-lfs...) then it's very probably properly stored in Git LFS

Tests

• GH Action running with latest version 3.1 doesn't work with PDF Files: feat: add dummy files to reproduce issue davidlj95/lfs-warning-test#1
• GH Action running with fixed version works with PDF files: feat: add dummy files with fixed version of GH Action davidlj95/lfs-warning-test#3

[davidlj95]

❓ Unsure about why diff in index.js is so big 🤔 I just did npm run package to generate it. Maybe because using Buffer?

[ppremk]

👋🏽 @davidlj95 @tsimbalar thank you for the contribution 💖 Apologies for not getting back ASAP. May I suggest that we resolve the conversations before the approval please? This will allow for a recorded audit on the decision we had taken for folks who may be following along. Also please ping me in here once it is resolved. I will be able to do the next steps 🙇🏽

[ppremk]

@davidlj95 @tsimbalar is there anything I can help to get this moving? 🙂

[davidlj95]

@davidlj95 @tsimbalar is there anything I can help to get this moving? 🙂

Hi @ppremk ! Thanks to you 😊

No worries, as you've seen, wasn't something urgent anyway :P Sorry for disconnecting about this a bit.

We just talked and resolved conversations. Will rebase, generate the new index.js and I think it will be ready to go 🚀

[davidlj95]

☝️ Done in b3077e6

[ppremk]

@davidlj95 Let's feel free to merge and ping me. I will proceed to cut a new release

[tsimbalar]

@davidlj95 can you merge it :P :P

[ppremk]

Merging on behalf

[tsimbalar]

Merging on behalf

Thanks @ppremk 👍

What is the next step for this change to be part of the next release ? :)

[ppremk]

@tsimbalar forgive me for missing out on this notification. Was OOO and travelling. I have blocked time to cut a new a release and add some release notes pointing to this Issue/PR. 🙇🏽 Thank you for your patience and continued support.

[tsimbalar]

Hi @ppremk is there any chance you can publish a release in the near future ? :)

[ppremk]

Hi @ppremk is there any chance you can publish a release in the near future ? :)

@tsimbalar thank you for the ping. It is now published. Please pardon the delay, this is on me for not getting to it on time. Please let know if there is anything else pending. 🙇🏽