Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for submenus to be subclasses of pygame.Menu #486

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

neilsimp1
Copy link
Contributor

See #482.

This is a very simple change. I've replaced the current if statement here to compare against the type pygame.Menu directly.

This works in my use case and for test/test_widget_button.py, but I have not performed any other testing on this.

@ppizarror ppizarror merged commit 2ae9db6 into ppizarror:master Oct 3, 2024
7 of 8 checks passed
@ppizarror
Copy link
Owner

Hi @neilsimp1. Thanks for your contribution. Indeed, this seems to be working. Committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants